"Show all discussions" button bug in "comments types as comments"

Quote

Total posts: 531
29 Apr 2015 12:48

Hello Sergey

I just found a small bug when using "cobalt types as comments" and set the "Limit" to 0 in "Comments list" area

when I set limit = 10 "show all discussions" button is gone when I set limit = 0 "show all discussions" button is showed

Which is wrong, it should be reverse instead, when limit = 10 show button, when limit = 0 hide button

Rgds

Last Modified: 30 Apr 2015

Quote

jimie

Total posts: 531
29 Apr 2015 12:58

Problem rize here:

library/php/comments/cobalt/cobalt.php

if($records['total'] > $type->params->get('comments.limit', 5))

there should be probably a special case if comments.limit parameter is set to 0 is should also not show the button

Quote

Sergey

Total posts: 13,748
30 Apr 2015 13:00

First there is not sence for this value to be 0. And also this button is shown only if there are more records that this amount. If you have 10 in parameters but only 3 articles in the list it means that it is less than 10 and there is no cense to show that button.

Login (copy)